Skip to content

Conversation

jaswanth8888
Copy link
Collaborator

Description

  • Added role checks in data source
  • Users with admin role can upload, delete documents
  • user with user role can only view the existing file

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

@chensuyue
Copy link
Collaborator

Please check the CI issue, can you pass the test locally?

@xiguiw
Copy link
Collaborator

xiguiw commented Dec 23, 2024

@jaswanth8888

This feature is useful.
Are you still working on this?

Copy link

github-actions bot commented Dec 23, 2024

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

@chensuyue
Copy link
Collaborator

Known issue: #1270

@xiguiw xiguiw requested a review from hteeyeoh as a code owner February 25, 2025 07:14
@xiguiw
Copy link
Collaborator

xiguiw commented Feb 25, 2025

Known issue: #1270
1270:
Let's wait for langserve 0.3.1 pypi release.
https://pypi.org/project/langserve/#history

Now 1270 is released.
Rerun CI to check now.

letonghan pushed a commit that referenced this pull request Sep 17, 2025
* Create token metrics only when they are available

This avoids generation of useless token/request histogram metrics
for services that use Orchestrator class, but never call its token
processing functionality.

(Helps in differentiating frontend megaservice metrics from backend
megaservice ones, especially when multiple OPEA applications run in
the same cluster.)

Also change Orchestrator CI test workaround to use unique prefix for
each metric instance, instead of metrics being (singleton) class
variables.

Signed-off-by: Eero Tamminen <[email protected]>

* Add locking for latency metric creation / method change

As that that could be called from multiple request handling threads.

Signed-off-by: Eero Tamminen <[email protected]>

---------

Signed-off-by: Eero Tamminen <[email protected]>
Co-authored-by: Malini Bhandaru <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants