This repository was archived by the owner on Jan 30, 2026. It is now read-only.
Add support for updated discovery.json#33
Merged
Conversation
Signed-off-by: Jose R. Gonzalez <komish@flutes.dev>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: komish The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
exe-prow-github-app
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for discover-workload's new discovery.json schema, which supports multiple container workloads referring to the same image.
This pull request also introduces simple logic to try and extract the "most likely container name" to stage as the component's name in the scaffolded product listing.
In the future, we may consider an interactive component here where a user could potentially choose one in real-time, but for now. this will just populate the product listing with the most common name, or the first name (if all names are equally common).
Signed-off-by: Jose R. Gonzalez komish@flutes.dev