This repository was archived by the owner on Jan 30, 2026. It is now read-only.
Automate checking for Pyxis schema updates#31
Merged
Conversation
komish
reviewed
Jun 17, 2025
caxu-rh
force-pushed
the
pyxis-schema-actions
branch
from
bbdceb7 to
bc88b7e
Compare
komish
reviewed
Jun 17, 2025
komish
reviewed
Jun 17, 2025
Signed-off-by: Caleb Xu <caxu@redhat.com>
caxu-rh
force-pushed
the
pyxis-schema-actions
branch
from
bc88b7e to
94be0db
Compare
exe-prow-github-app
Bot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: caxu-rh, komish The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
exe-prow-github-app
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces:
ci.generatewhich wraps around the existinggeneratetarget. Works similarly to otherci.*tasks: do some operation on the codebase and check if there is a diff.schema.gqlorgenerated.go, after runningmake ci.generate. If there is a diff in either of those files, it is committed into a new branch, pushed, and a PR is opened.workflow_dispatch, i.e. manually. I figured it would be best to get a bit more confidence in this process (and decide on update frequency) before further adjusting it to run on a schedule.schema-updatelabel present. We can adjust the exact naming of the label to look for as needed.schema.gqlorgenerated.go. My thought was to put it in the existing pull request workflow, to catch both manual and automated updates of these files. However, if manual updates of these files is not a concern, we can also just add the labeling logic into this workflow.To test this workflow, I checked out a separate branch on my own fork,
pyxis-schema-update-test, and reset it backwards to be right before #29 was merged, then added these changes on top.I then tried (1) manually running the workflow (no pull request for the update exists yet, and there is a diff that should be committed/pushed) which created a PR (which I manually labeled), (2) running the workflow again without merging the newly created PR (this run exits early to avoid creating a duplicate PR), and then after merging, (3) running the workflow again (there is no longer a diff, so the check happens but no PR is created).