Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More closely align cookbook with common tar functionality #12

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

bbbco
Copy link

@bbbco bbbco commented Dec 16, 2015

This will better enable users to use the cookbook, as this more closely aligns with how tar parameters are actually interacted with.

  • Allows users to specify specific shell globs to use in the extract_list
  • Allows users to specify files to exclude (via shell globs again)
  • Allows users to specify a level to strip components (simulating the --strip-components parameter).
  • Allows users to specify the mode to overwrite file permissions

I also added tests for the new features.

@bbbco bbbco changed the title Use shell globbing to determine whether to extract files More closely align cookbook with common tar functionality Dec 17, 2015
@irabinovitch
Copy link
Contributor

@bbbco Thanks for writing this up! Can you take a look at the rubocop failures?

In the meantime paging a few folks for their feedback

CC: @ooyala/open-source-tar-cookbook @Quanqued @edanaher @kbruner

@bbbco
Copy link
Author

bbbco commented Dec 18, 2015

Yeah no problem! I tweaked a couple of things on the spec and forgot to run rubocop. Will fix up shortly.

@jorhett
Copy link

jorhett commented Mar 22, 2016

sorry we dropped the ball due to some staff changes. I'll review this and get back to you soon

@bbbco
Copy link
Author

bbbco commented Mar 22, 2016

FWIW, we decided to move on from this cookbook, mainly because Ruby's Tar Reader cannot handle reading big files. We are using a cookbook that wraps the distro's tar command underneath. Thanks!

@ghost
Copy link

ghost commented May 19, 2016

Will this be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants