Skip to content

Function to encode strings #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
miguelleitao wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Function to encode strings #3

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
234c272
encoding
miguelleitao Oct 23, 2017
665707d
stdio added
miguelleitao Oct 23, 2017
92cd2bc
encode declaration
miguelleitao Oct 23, 2017
087ef2b
size_t return
miguelleitao Dec 27, 2017
28ea301
const cast in cmp() to improve compatibility
miguelleitao Dec 28, 2017
20d7f5e
encoding with full test
miguelleitao Dec 28, 2017
4626491
added commat; entitie
miguelleitao Dec 28, 2017
1e13e72
encoding test
miguelleitao Dec 28, 2017
e6a49b5
encoding
miguelleitao Oct 23, 2017
81026a7
stdio added
miguelleitao Oct 23, 2017
d33c982
encode declaration
miguelleitao Oct 23, 2017
0fe8c7f
size_t return
miguelleitao Dec 27, 2017
3a3b17a
encoding with full test
miguelleitao Dec 28, 2017
b15161a
encoding test
miguelleitao Dec 28, 2017
eeb211f
Misc stylistic unification
ooxi Dec 29, 2017
aea9a89
Merge branch 'feature/encode' of https://github.com/ooxi/entities
miguelleitao Dec 31, 2017
96769f8
Merge branch 'ooxi:master' into master
miguelleitao May 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions entities.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,3 +390,32 @@ size_t decode_html_entities_utf8(char *dest, const char *src)
return (size_t)(to - dest);
}

int encode_html_entities(char *dest, const char *src) {
Copy link
Owner

@ooxi ooxi Dec 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please return sitze_t instead of int

Copy link
Contributor Author

@miguelleitao miguelleitao Dec 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely agree. I'll commit the correction.

char *to = dest;
for( const char *from = src ; *from ; from++ ) {
int i = 9999;
Copy link
Owner

@ooxi ooxi Dec 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please declare i as late as possible and do not assign a magic unused value to it

Copy link
Contributor Author

@miguelleitao miguelleitao Dec 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely agree. I'll commit the correction.

if ( *from <= '+' ) {
sprintf(to,"%%%02x",*from);
to += 3;
continue;
}
if ( *from<='z' ) {
*to = *from;
to++;
continue;
}
//if ( *from=='\r' || *from=='\n' ) continue;
for( i=0 ; i<sizeof NAMED_ENTITIES / sizeof *NAMED_ENTITIES ; i++ )
if ( *from == NAMED_ENTITIES[i][1][0] ) break;
Copy link
Owner

@ooxi ooxi Dec 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really get this logic :-) are you comparing just the first character or am I missing something? Or is this sufficient because of the available entities (then please make sure this remains the case by adding an appropriate test case)

Copy link
Contributor Author

@miguelleitao miguelleitao Dec 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm just comparing the first character. I found this sufficient for the final application I was developing. Maybe this encoder should be classified as an ASCII encoder instead of an UTF-8 encoder. I'll think about this during next week. Enlarging the length of the test can be done but this solution will still be inefficient since it uses a top-down search on an unsorted table.
If I won't improve the test, I'll try to keep the restriction clear to future users or developers.
Any way, I'll provide a test case.

if ( i<sizeof NAMED_ENTITIES / sizeof *NAMED_ENTITIES ) {
strcpy(to,NAMED_ENTITIES[i][0]);
to += strlen(NAMED_ENTITIES[i][0]);
}
else {
*to = *from;
to++;
}
}
*to = 0;
return strlen(dest);
Copy link
Owner

@ooxi ooxi Dec 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you know dest and to, no call to strlen is necessary

Copy link
Contributor Author

@miguelleitao miguelleitao Dec 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely agree. I'll commit the correction.

}