-
Notifications
You must be signed in to change notification settings - Fork 5.9k
feat: Add multi-user profiles to mirror character profiles #7367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+228
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
P4X-ng
approved these changes
Jan 10, 2026
Ensures proper resource cleanup by using 'with' statement instead of bare open() call when reading user profile files.
Changes height from calc(100vh - 231px) to calc(100vh - 334px) to properly fit the UI with the new user menu controls.
Owner
|
Thanks for the PR! The implementation is very clean and integrates well with the existing code. I made just a few minor improvements. Merging now. |
This was referenced Jan 14, 2026
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I sometimes want a different 'persona' for my own user depending on the other character I'm going to be chatting with. But since the UI only had one default character with a single name and field, I would have to keep a text file and copy/paste all the details about the user I was going to be for the chat.
But a while ago I started to get annoyed by doing that change everytime, so I patched this locally so I could save variations of 'me' for different chats.
I just updated to the latest release and I figure there's probably others who would like the same functionality, so I decided to file a PR.
I'm happy to make any modifications or changes that you would prefer to what I've written. I tried to follow your existing code style by where possible by re-using existing lines that were close to what I needed and then modifying them as required. Like the Character Saver in
ui_file_saving.pywhere I clonedL29-40toL42-53for the User saver and then updated the necessary strings.But I'm happy to make any changes you want.
Checklist:
I ran through all the files I changed with pyflakes and pycodestyle. No output from either linter.