Fix for Copy Button (with HTTP Fallback) #7358
Merged
+84
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
Owner
|
What is the issue fixed by this change? And how does the change work? |
P4X-ng
approved these changes
Jan 10, 2026
Author
|
the copy button works without SSL, for example in a private LAN there is no need to set up SSL and then the copy button works |
The HTTP fallback will be implemented directly in highlightjs-copy.min.js instead.
The Clipboard API requires a secure context (HTTPS). This adds a
fallback using document.execCommand('copy') for HTTP environments,
enabling the copy button to work on local networks without SSL.
Owner
|
Nice, thanks for the PR! I wasn't aware of this issue with code blocks on HTTP. I refactored the fix to patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: