Features/1.10 ready #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@severin I'd need help adding this project to codeship, no permissions for that again 😉 while at it, any chance you could add the |
severin
approved these changes
Aug 19, 2020
There was a problem hiding this comment.
@rkorzeniec I tested the following combinations:
- main app master branch: 24s for the query, thereof 90ms database time, no N+1 queries in the logs ✅
- main app updates/graphql-1.10 branch using this repo's master: 29s for the query, thereof 3+s database time, lots of N+1 queries ⛔
- main app updates/graphql-1.10 branch using this PR's branch: 22s for the query, 90ms database time, no N+1 queries ✅
I quickly skimmed the code but did not thoroughly review it. If you wish me to do that please rerequest review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should (tested on the main app) make the graphql-preload gem ready for the new AST interpreter.
Changes in this PR are heavily based on ConsultingMD#25, with few minor changes, by making it more modular and properly using the options hash for field extensions.
The branch on the main app is
updates/graphql-1.10.The page I tested the preloading on http://localhost:3001/en-ch/explore/womens
You can compare using the original gem (or pointing to master) of this fork and pointing to this branch. The amount of DB calls and N+1s drops severely.
P.S. - also one day we might be forced to do this one too... ConsultingMD#32