Introduce insert_nodes convenience function

[Johansmm]

Convenience function to insert a set of nodes in an ir.Value(s).

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.83%. Comparing base (d19f998) to head (f077782).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
+ Coverage   73.59%   73.83%   +0.23%     
==========================================
  Files          37       37              
  Lines        4492     4521      +29     
  Branches      902      907       +5     
==========================================
+ Hits         3306     3338      +32     
+ Misses        858      856       -2     
+ Partials      328      327       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[justinchuby]

Could you share a use case for this function? I am trying to think what the best api for it should be. Right now the order of appearance of the node inputs implicitly matches the values, which may not be ideal. Also the function name may be improved to be more accurate and succinct.

If we generalize this method, what should an “insert_nodes” api do?

[Johansmm]

I am thinking in some case that is needed to insert new nodes without remove previous ones. Following: microsoft/onnxscript#2064 discussion, this is not possible to do this with onnxscript.rewriter, since rewrite_pattern have to redefine target_pattern.

Moreover I believe with this helper it is easer to include new nodes with something like

for node in ir_model.graph:
    if node.op_type == 'expected_op_type':
        insert_node(node.outputs[0], [new_node])

I found this ease to understand/use.

[Johansmm]

For your other comment (about order), do you have any suggestion ? When len(values) > 1, I though was a good idea to infer the inputs for the list of nodes keeping the order, being needed to change the position of nodes in the list if values need to be re-order.

Maybe it would be enough if it is better specified in the use of the function, right?

[justinchuby]

I wonder if something like this would make sense:

def insert_nodes(values, nodes, incoming_values, outgoing_values)

or if the new nodes are connected linearly

def insert_nodes(values, nodes)

(we can constrain that the inputs only be the first node, and the outputs only be produced by the last node so that the intention is clear)

[justinchuby]

sorting after insertion is not ideal. Is there a way to efficiently find the insertion point?