-
-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Python 3.10 to 3.13 #1623
Conversation
https://github.com/PyO3/pyo3/releases/tag/v0.23.0 and https://github.com/PyO3/pyo3/releases/tag/v0.23.1 are now available with support for building Python 3.13 wheels. |
I've created #1646 just now to see if this is possible now without much issues as suggested by @MaxHalford. That PR targets this branch instead of the |
I can't see the failures in #1646, but I do see them after I try to build wheels locally. I have no experience with writing code in Rust whatsoever, so I'm not sure if I can help with this too much beyond reading the PyO3 docs, bumping the version gradually, one by one, and trying to figure out how to fix the code 😅 So I'd rather leave this for someone else who is more experienced than I am at this. |
4e1a8c9
to
1640bd1
Compare
- Drop support for 3.9 - Add support for 3.13 - Fix unit-tests workflow to use matrix for Python versions
4c6b8ec
to
006267f
Compare
Thanks, @gbolmier! I think the difference was that PyO3 can build Python 3.13 wheels already, but not Python 3.13t free-threaded wheels – support for which was brought forward in the recent version 0.23.1 that I was trying to upgrade to. But then, that does make me think how PyO3 version 0.18 is able to compile for Python 3.13 here, since support for Python 3.13 itself was brought in https://github.com/PyO3/pyo3/releases/tag/v0.22.0 – but everything passes, so no complaints! 😁 |
Hey @agriyakhetarpal, @AdilZouitine is atm looking into bumping PyO3 to |
Yes, I'm glad to hear that, @gbolmier! I had backported the necessary changes by re-doing them on top of 0.21.0 momentarily; it's much nicer for us to rely on a released version. 😁✌️ |
Hey @agriyakhetarpal, we bump the version #1648 on this pull request 😄 |
Changes
Notes
Recent
PyO3=0.23.0
release added support for python 3.13 but bumping it to0.23.1
leads torust_src
compilation errors (cc @AdilZouitine).CI builds river and run unit-tests successfully with the current
PyO3=0.18.3
so it should be fine to merge as it is.