Feature/partners #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeOleg
approved these changes
Feb 14, 2020
BeOleg
reviewed
Feb 14, 2020
|
|
||
| } | ||
|
|
||
| module.exports = Emon; No newline at end of file |
BeOleg
requested changes
Feb 14, 2020
Contributor
BeOleg
left a comment
BeOleg
left a comment
There was a problem hiding this comment.
new lines at the end of file please, more tests, also where is this n.exhange to n.exchange/en redirect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WAITING FOR REVIEW
Issue:
Various partners send valuable info in GET or REFERER parameters, like language, currency pair or card payment request. We can use these to show the right setup for the users.
Solution:
A collection of partner classes that process the HTTP parameters and give back the correct values depending on from which partner the traffic comes from.