Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trace generation and GCP uploading functionality #6841

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

m-Peter
Copy link
Collaborator

@m-Peter m-Peter commented Dec 29, 2024

Closes #6840

Note: Removes also the following execution config flags:

  • --evm-tracing-enabled
  • --evm-traces-gcp-bucket

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.16%. Comparing base (72adf9e) to head (8c03eb5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6841      +/-   ##
==========================================
- Coverage   41.18%   41.16%   -0.02%     
==========================================
  Files        2109     2107       -2     
  Lines      185660   185360     -300     
==========================================
- Hits        76460    76301     -159     
+ Misses     102788   102655     -133     
+ Partials     6412     6404       -8     
Flag Coverage Δ
unittests 41.16% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@janezpodhostnik janezpodhostnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks.

I think its safest if we deploy this during an HCU.

@m-Peter m-Peter force-pushed the mpeter/decommission-evm-trace-generation branch from 864797e to 8c03eb5 Compare January 6, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flow EVM] Decommission the traces generation & GCP upload
3 participants