Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flow EVM] port missing tracing updates to previewnet #6324

Conversation

ramtinms
Copy link
Contributor

@ramtinms ramtinms commented Aug 12, 2024

Some tracing changes seems to have dropped during the porting to the previewnet

@ramtinms ramtinms marked this pull request as ready for review August 12, 2024 17:46
@ramtinms ramtinms requested a review from j1010001 August 12, 2024 17:47
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 33.06452% with 83 lines in your changes missing coverage. Please review.

Project coverage is 41.54%. Comparing base (7a5e079) to head (669d3e2).

Files Patch % Lines
fvm/evm/debug/tracer.go 33.06% 75 Missing and 8 partials ⚠️
Additional details and impacted files
@@                       Coverage Diff                        @@
##           feature/crescendo-previewnet    #6324      +/-   ##
================================================================
- Coverage                         41.57%   41.54%   -0.04%     
================================================================
  Files                              1852     1992     +140     
  Lines                            134840   141601    +6761     
================================================================
+ Hits                              56066    58828    +2762     
- Misses                            72887    76646    +3759     
- Partials                           5887     6127     +240     
Flag Coverage Δ
unittests 41.54% <33.06%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ramtinms ramtinms merged commit 5a1d049 into feature/crescendo-previewnet Aug 12, 2024
55 checks passed
@ramtinms ramtinms deleted the ramtin/evm-port-missing-tracing-changes-to-cresendo branch August 12, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants