Skip to content

Conversation

peterargue
Copy link
Contributor

Closes: #???

Description

Possible approach to reduce boilerplate for unimplemented methods


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@bluesign
Copy link
Contributor

bluesign commented Mar 10, 2025

This feels a bit wrong. ( according to https://github.com/onflow/flow-go-sdk/tree/master/access )

Each implementation (currently grpc and http) include the following parts:
Base Client is the client that implements the client interface exposing all generic functionality.
Client is the network specific client that exposes any additional options possible by the specific API implementation.
Handler takes care of actual network communication implementing the communication protocol.

Shouldn't all functions in generic ( I think this means common subset ) implemented as exposed as interface ?

PS: I think this is somehow issue with initial implementation not this PR

@peterargue peterargue changed the title Update access interface to align with latest changes Add unimplemented interface Mar 11, 2025
Base automatically changed from peter/update-access-interface to master March 11, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants