Skip to content

[Subtyping Generator] Improve subtype check generation #4299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Parent: [Subtyping Generator] Generate subtype checking rules from a DSL
wants to merge 3 commits into
base: supun/subtype-gen
Choose a base branch
from
Open

[Subtyping Generator] Improve subtype check generation #4299

wants to merge 3 commits into from

Conversation

@SupunS
Copy link
Member

@SupunS SupunS commented Oct 15, 2025 •
edited
Loading

Work towards #3691

Depends on #4262

Description

Adds a few improvements suggested in #4297:

  • Rename the properties of setContains:
    • source to set
    • target to element
  • Replace constructorEqual predicate with equals
  • Some code refactoring.
  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@SupunS SupunS self-assigned this Oct 15, 2025
@SupunS SupunS marked this pull request as ready for review October 15, 2025 20:41
@SupunS SupunS mentioned this pull request Oct 20, 2025
Draft
6 tasks
turbolent
turbolent approved these changes Oct 23, 2025
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@turbolent turbolent turbolent approved these changes

@RZhang05 RZhang05 RZhang05 approved these changes

Assignees

@SupunS SupunS

Labels

Improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SupunS @turbolent @RZhang05