-
Notifications
You must be signed in to change notification settings - Fork 143
Pretty print error messages in testing framework #4289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
devin-ai-integration
wants to merge
1
commit into
master
Choose a base branch
from
devin/1760465548-pretty-print-test-errors
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Pretty print error messages in testing framework #4289
devin-ai-integration
wants to merge
1
commit into
master
from
devin/1760465548-pretty-print-test-errors
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add formatValueForTestOutput helper function to format values with pretty-printed errors - Handle Test.Error values by showing raw message content instead of escaped newlines/tabs - Support recursive formatting for ScriptResult and TransactionResult - Unwrap optional values (SomeValue) to access nested Error values - Add test to verify newlines and tabs in error messages are not escaped Fixes #3403
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Benchstat comparison
Results
|
12 tasks
(aside) I'm not sure the solution is what we're looking for, will pick this up later when we have time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3403
Description
This PR improves error message readability in the Cadence testing framework by pretty-printing error messages with actual newlines and tabs instead of escaped sequences.
Problem
When tests fail with error messages containing newlines (
\n
) or tabs (\t
), the testing framework was displaying them as escaped sequences, making the output hard to read:Solution
Added a
formatValueForTestOutput
helper function that:Test.Error
values and extracts the raw message string without escapingScriptResult
andTransactionResult
to apply pretty-printing to nested errorsSomeValue
) since error fields are optional typesNow errors display with actual formatting:
Key Changes
stdlib/test_contract.go
: AddedformatValueForTestOutput
andformatValueForTestOutputHelper
functionsnewTestTypeExpectFunction
to use the new formatterstdlib/test_test.go
: Added test case to verify newlines and tabs are not escapedReview Focus
strings.HasSuffix(typeID, ".Test.Error")
to identify Error types - verify this is robustSomeValue
unwrapping is critical since error fields are optional - this was the key bugLink to Devin run: https://app.devin.ai/sessions/d951b3c6a2f94efa97ac0a2f088b1f11
Requested by: [email protected]
master
branchFiles changed
in the Github PR explorer