-
Notifications
You must be signed in to change notification settings - Fork 15
Add parallelism to tests to reduce atree test duration (64m -> 31m) #584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Currently, tests in CI are taking over an hour to run. This commit reduces test duration by using parallelism. This change does not modify anything that affects the behavior of software on testnet or mainnet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Maybe it might make sense to have a set of quick unit tests that run in an even shorter time, and smoke tests that run periodically? Alternatively we might want to run the tests with a larger runner?
Some subtests were extracted in order to allow more tests to run in parallel. However, it can be tedious to review on GitHub because the diff shows additions and substractions intermingled. This commit moves the extracted subtests to the end of file, to make the diff easier to read by having these additions separated from the subtractions. This commit also restores some previously extracted functions for better Git readability. Maybe we can address this in a separate PR.
2d93ba2
to
13d5be1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for re-arranging the tests, the diff was much easier to review afterwards.
Nice work!
BTW, removing the |
Closes #583
Currently, tests in CI are taking over an hour to run.
This PR reduces test duration by using parallelism: 64m → 31m
This change does not modify anything that affects the behavior of software on testnet or mainnet.
main
branchFiles changed
in the Github PR explorer