Keep Canvas completion reminders until the pane is visible - #785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A Canvas pane can keep keyboard focus after panning moves its card completely outside the viewport. Such a pane must retain its unread Done state until it returns to view.
Continue the Canvas acknowledgement implementation from #783, with its original commit preserved. Require the focused terminal's bounds to intersect its AppKit visible rectangle, in addition to the original key/visible-window and actual-responder checks. Partial visibility is sufficient. Keep navigation, broadcast input, and worktree-scoped notification behavior unchanged.
The completion-read prerequisite #781 is merged. This branch includes that implementation, and the combined behavior was tested locally.
Fixes #779.
Validation
visibleRectcan be nonempty but outside the terminal bounds; the predicate uses rectangle intersection.make checkpassed, including 146 script tests.make build-apppassed.git diff --checkpassed.Original contribution
Thanks to @SunChJ (SamsonCJ) for the Canvas implementation in #780, resubmitted as #783. Original commit
3635ff56d1f001e70fc7422ab8666da8523b6883is retained unchanged as an ancestor of this branch. This follow-up adds viewport coverage and combined behavior tests. Thanks to @onevtail for reporting the offscreen case.Use a merge commit to retain the original contribution in repository history.