Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run callbacks around scrubbing #6

Merged
merged 1 commit into from
Mar 20, 2018

Conversation

adamstegman
Copy link
Member

This will allow for action to be taken on specific records before and after scrubbing, as opposed to after all scrubbing is done in the global after hook.

Specifically, this will avoid issues like ActsAsParanoid/acts_as_paranoid#45 by allowing us to cache the paranoid_value and restore it afterward.

Copy link

@jeremiemv jeremiemv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamstegman adamstegman merged commit 41c7382 into master Mar 20, 2018
@adamstegman adamstegman deleted the bug/156062828-destroyed-objects branch March 20, 2018 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants