Fixed bug with zero depth ur_rect_region_t which must be checked before calling funcs
#2746
Conversation
Unified Runtime -> intel/llvm Repo Move NoticeInformationThe source code of Unified Runtime has been moved to intel/llvm under the unified-runtime top-level directory, The code will be mirrored to oneapi-src/unified-runtime and the specification will continue to be hosted at oneapi-src.github.io/unified-runtime. The contribution guide will be updated with new instructions for contributing to Unified Runtime. PR MigrationAll open PRs including this one will be marked with the Should you wish to continue with your PR you will need to migrate it to intel/llvm. If your PR should remain open and not be closed automatically, you can remove the This is an automated comment. |
| @@ -4807,7 +4807,7 @@ __urdlllocal ur_result_t UR_APICALL urEnqueueMemBufferReadRect( | |||
| if (phEventWaitList != NULL && numEventsInWaitList == 0) | |||
| return UR_RESULT_ERROR_INVALID_EVENT_WAIT_LIST; | |||
|
|
|||
| if (region.width == 0 || region.height == 0 || region.width == 0) | |||
| if (region.width == 0 || region.height == 0 || region.depth == 0) | |||
There was a problem hiding this comment.
thanks for the fix, note this is a generated file so this change will need to be made here, and you'll need to then run the generate target to propagate the update to the headers + validation layer
There was a problem hiding this comment.
@aarongreig, Im fixed here: 5a5811a
There was a problem hiding this comment.
Cool, thanks. Sorry I should have also reiterated the bot comment: this repo isn't used for development any more, it's purely a mirror of https://github.com/intel/llvm/tree/sycl/unified-runtime so you'll need to migrate this PR to that repo
github-actions
bot
added
the
specification
… calling func Fixed functions: - urEnqueueMemBufferWriteRect() - urEnqueueMemBufferReadRect()
…efore calling func (#17681) Its PR migrated from oneapi-src/unified-runtime#2746 It looks like a common typo when writing functions. Fixed functions: - urEnqueueMemBufferWriteRect() - urEnqueueMemBufferReadRect() Co-authored-by: Nicolas Miller <[email protected]>
… calling func (#17681) Its PR migrated from #2746 It looks like a common typo when writing functions. Fixed functions: - urEnqueueMemBufferWriteRect() - urEnqueueMemBufferReadRect() Co-authored-by: Nicolas Miller <[email protected]>
…efore calling func (intel#17681) Its PR migrated from oneapi-src/unified-runtime#2746 It looks like a common typo when writing functions. Fixed functions: - urEnqueueMemBufferWriteRect() - urEnqueueMemBufferReadRect() Co-authored-by: Nicolas Miller <[email protected]>
Automatic PR Closure NoticeInformationThis PR has been closed automatically. It was marked with the All Unified Runtime development should be done in intel/llvm, details can be found in the updated contribution guide. Next StepsShould you wish to re-open this PR it must be moved to intel/llvm. We have provided a script to help automate this process, otherwise no actions are required. This is an automated comment. |
@RossBrunton, it looks like a common typo when writing functions.
Fixed functions: