fix nightly windows build #1538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
force-pushed
the
rrudnick_fix_win
branch
from
f7e7c3e to
1afb113
Compare
lplewa
reviewed
Oct 21, 2025
| params, residentDevices.data(), residentDevices.size()), | ||
| UMF_RESULT_SUCCESS); | ||
| EXPECT_EQ( | ||
| umfLevelZeroMemoryProviderParamsSetResidentDevices( |
There was a problem hiding this comment.
NIT: maybe this function should accept size_t instead of uint32_t - i think other functions in UMF uses size_t in similar places
There was a problem hiding this comment.
we are not consistent here - this was missed in API 1.0 review :( e.g.
umf_result_t umfOsMemoryProviderParamsSetNumaList(
umf_os_memory_provider_params_handle_t hParams, unsigned *numa_list,
unsigned numa_list_len);
lplewa
approved these changes
Oct 21, 2025
lukaszstolarczuk
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix nightly windows build
fixed build: https://github.com/oneapi-src/unified-memory-framework/actions/runs/18684983581/job/53275092023?pr=1538