Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graph, benchdnn: several minor fixes for SDPA with mask #2660

Merged
merged 5 commits into from
Feb 13, 2025
Merged

graph, benchdnn: several minor fixes for SDPA with mask #2660

merged 5 commits into from
Feb 13, 2025

Conversation

ElaineBao
Copy link
Contributor

Description

This PR includes 3 minor fixes for SDPA with explicit or implicit mask:
[x] enhance check of axis in implicit causal mask to include negative axis (-1 & -2).
[x] support 1D / 2D mask for explicit causal mask (MFDNN-13164).
[x] add a internal attribute for internal op dnnl_gen_index for constant propagation (SET_ATTR_IS_CONSTANT)

@ElaineBao ElaineBao added the component:graph-api Codeowner: @oneapi-src/onednn-graph label Feb 11, 2025
@ElaineBao ElaineBao self-assigned this Feb 11, 2025
@ElaineBao ElaineBao requested review from a team as code owners February 11, 2025 13:40
@github-actions github-actions bot added the component:tests Codeowner: @oneapi-src/onednn-arch label Feb 11, 2025
TaoLv
TaoLv reviewed Feb 11, 2025
View reviewed changes
Copy link
Contributor

@TaoLv TaoLv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also make a PR for rls-v3.7? Let's see if we have any chance to fix them also before the release.

src/graph/backend/dnnl/kernels/sdp_primitive_config.cpp Show resolved Hide resolved
@ElaineBao ElaineBao force-pushed the yixin/sdpa_minor_fix branch from 97a7d24 to fbb6c3f Compare February 12, 2025 01:20
@ElaineBao
Copy link
Contributor Author

make test
set test_scope=NIGHTLY
disable benchdnn_all
enable benchdnn_graph

@ElaineBao ElaineBao force-pushed the yixin/sdpa_minor_fix branch from fbb6c3f to 16d1809 Compare February 12, 2025 02:32
@ElaineBao ElaineBao mentioned this pull request Feb 12, 2025
Merged
@ElaineBao
Copy link
Contributor Author

make test
set test_scope=NIGHTLY
disable benchdnn_all
enable benchdnn_graph

@ElaineBao ElaineBao force-pushed the yixin/sdpa_minor_fix branch from 16d1809 to a66be96 Compare February 12, 2025 16:33
@ElaineBao
Copy link
Contributor Author

make test
set test_scope=NIGHTLY
disable benchdnn_all
enable benchdnn_graph

@ElaineBao ElaineBao force-pushed the yixin/sdpa_minor_fix branch from a66be96 to ebbb934 Compare February 13, 2025 02:58
@ElaineBao
Copy link
Contributor Author

make test
set test_scope=NIGHTLY
disable benchdnn_all
enable benchdnn_graph

@ElaineBao ElaineBao force-pushed the yixin/sdpa_minor_fix branch from ebbb934 to e1dd66f Compare February 13, 2025 04:03
@ElaineBao
Copy link
Contributor Author

make test
set test_scope=NIGHTLY
disable benchdnn_all
enable benchdnn_graph

@TaoLv TaoLv merged commit 4c34f83 into main Feb 13, 2025
24 of 25 checks passed
@TaoLv TaoLv deleted the yixin/sdpa_minor_fix branch February 13, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TaoLv TaoLv TaoLv approved these changes

@rongzha1 rongzha1 rongzha1 approved these changes

@dzarukin dzarukin dzarukin approved these changes

@gyhintel gyhintel gyhintel approved these changes

Assignees

@ElaineBao ElaineBao

Labels
component:graph-api Codeowner: @oneapi-src/onednn-graph component:tests Codeowner: @oneapi-src/onednn-arch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ElaineBao @TaoLv @rongzha1 @dzarukin @gyhintel