fixup: src: introduce quant_entry_t and refactor arg_scales_t to rely on it #2657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
platform:cpu-aarch64
… on it This fixes #2572. Patches aarch64 brgemm dispatching without scales involved.
dzarukin
force-pushed
the
dzarukin/fix_aarch64_brgemm
branch
from
58fa6ad to
7264c57
Compare
vpirogov
approved these changes
Feb 12, 2025
|
ping @oneapi-src/onednn-cpu-aarch64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2572.
Patches aarch64 brgemm dispatching without scales involved.
@Ryo-not-rio, you probably may use this commit for your performance regression tracking. It's a dispatching issue, performance should increase significantly (or should have caught a major regression).