Backport: cpu: fixes coverity issues #2630
Merged
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
platform:cpu-x64
|
make test |
avmanerikar
approved these changes
Feb 7, 2025
densamoilov
reviewed
Feb 7, 2025
| @@ -100,7 +100,7 @@ struct simple_sparse_reorder_impl<SIMPLE_SPARSE_REORDER_TEMPL_CALL, | |||
|
|
|||
| static size_t get_scratchpad_size(const memory_desc_wrapper &input_d, | |||
| const memory_desc_wrapper &output_d) { | |||
| const auto nelems = static_cast<size_t>(output_d.nelems(true)); | |||
There was a problem hiding this comment.
nelems can only return < 0 when one of the dimensions is runtime because this is how wildcard defined:
oneDNN/include/oneapi/dnnl/dnnl_types.h
Line 2279 in c07fe05
This reorder doesn't support runtime dimensions so we return unimplemented before we can reach this place so it is safe to keep size_t.
densamoilov
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #2619