cpu: Fixes some coverity issues (copy instead of move, const auto instead of const auto&). #2626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tead of const auto&).
github-actions
bot
added
the
platform:cpu-x64
xuxinzen
reviewed
Feb 7, 2025
| @@ -196,7 +196,7 @@ struct ref_fused_convolution_fwd_t : public primitive_t { | |||
| arg_cache.append_inout_arg( | |||
| DNNL_ARG_FROM, sp_begin, from_md, true); | |||
| arg_cache.append_inout_arg(DNNL_ARG_TO, sp_end, to_md, false); | |||
| args_.push_back(arg_cache); | |||
| args_.push_back(std::move(arg_cache)); | |||
|
|
|||
There was a problem hiding this comment.
I did not see related coverity issue in the latest Coverity report. Could you point me out the CID or check if these changes are needed?
There was a problem hiding this comment.
There are a variety of CIDs represented here, but they are in the minor category. This particular one is 6925574.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cpu: Fixes some coverity issues (copy instead of move, const auto instead of const auto&).