xe: jit: gemm: remove unnecessary register duplication #2625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
platform:gpu-intel
Fixes an out of registers failure on XeLP systems for the following workload: ``` benchdnn --matmul --engine=gpu --dt=bf16:s4:bf16 --wtag=acb --attr-scales=wei:per_ocic:bf16:32x1 --attr-zero-points=wei:per_ocic:s4:32x1 --attr-fpmath=bf16:true 3x96x96:3x96x64 ``` On this workload, a duplicated scalar is the only subregister allocation present in r1.
rjoursler
force-pushed
the
rjoursle/fix_out_of_registers
branch
from
cf7072f to
c62ec58
Compare
|
make test |
petercad
approved these changes
Feb 7, 2025
kealan-barbieri
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an out of registers failure on XeLP systems for the following workload:
On this workload, a duplicated scalar is the only subregister allocation present in r1. Removing this duplication thereby frees a register and avoids kernel generation failure.
Fixes MFDNN-13167.