-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github: workflows: Move CI into dedicated AArch64 folders #2615
Conversation
Discovered that creating subfolders inside workflows is not going to work.. Disappointing. Well, I'll keep "aarch64" in the name of all AArch64 workflows so we can regex them. And I'll continue with moving automation scripts into an AArch64 subfolder. |
375b731
to
40f3a3e
Compare
This gift keeps on giving - we have "build*" in the gitignore, so I can't add build.sh to an AArch64 folder.. So now I have to add a redundant aarch64-build.sh in the aarch64 folder.. Edit: Actually, I will change the gitignore to "build/*", which is more sensible. |
1fb2872
to
fe7fc58
Compare
Looks like a lot of people are upset with this quirk: https://github.com/orgs/community/discussions/15935 |
fe7fc58
to
074af42
Compare
This does not sound right. There are build.sh/build.bat files sitting in .github/automation. |
@vpirogov : I think the "build*" edit to gitignore was made after the scripts were already in. But no worries, I changed it to "/build*" and now it will only match build* folders in root, which is what we want. |
90e0bd7
to
c5e72c5
Compare
My git (2.40.1) still does not bark at new files with 'build' in the name. But your fix makes sense based on .gitignore documentation. |
@vpirogov : ready. |
Do you want to update x64 CI trigger as part of this PR as well? |
532c1cf
to
c5e72c5
Compare
Signed-off-by: Hamza Butt <[email protected]>
c5e72c5
to
06241c1
Compare
@vpirogov : I tried many (10) times and still couldn't get Azure to skip, so I gave up. Could you take a look? |
@vpirogov suggests to separate AArch64 CI into dedicated folders.
Requires a bit of testing, will update PR when ready. Can't check nightly is OK until this PR is merged to main, but we can test precommit.