Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: workflows: Move CI into dedicated AArch64 folders #2615

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

theComputeKid
Copy link
Member

@vpirogov suggests to separate AArch64 CI into dedicated folders.

Requires a bit of testing, will update PR when ready. Can't check nightly is OK until this PR is merged to main, but we can test precommit.

@github-actions github-actions bot added the devops Github automation label Feb 6, 2025
@theComputeKid
Copy link
Member Author

theComputeKid commented Feb 6, 2025

Discovered that creating subfolders inside workflows is not going to work.. Disappointing. Well, I'll keep "aarch64" in the name of all AArch64 workflows so we can regex them. And I'll continue with moving automation scripts into an AArch64 subfolder.

@theComputeKid theComputeKid force-pushed the theComputeKid/ci branch 2 times, most recently from 375b731 to 40f3a3e Compare February 6, 2025 16:21
@theComputeKid
Copy link
Member Author

theComputeKid commented Feb 6, 2025

This gift keeps on giving - we have "build*" in the gitignore, so I can't add build.sh to an AArch64 folder.. So now I have to add a redundant aarch64-build.sh in the aarch64 folder..

Edit: Actually, I will change the gitignore to "build/*", which is more sensible.

@theComputeKid theComputeKid force-pushed the theComputeKid/ci branch 2 times, most recently from 1fb2872 to fe7fc58 Compare February 6, 2025 16:29
@vpirogov
Copy link
Member

vpirogov commented Feb 6, 2025

Discovered that creating subfolders inside workflows is not going to work.. Disappointing. Well, I'll keep "aarch64" in the name of all AArch64 workflows so we can regex them. And I'll continue with moving automation scripts into an AArch64 subfolder.

Looks like a lot of people are upset with this quirk: https://github.com/orgs/community/discussions/15935

@vpirogov
Copy link
Member

vpirogov commented Feb 6, 2025

This gift keeps on giving - we have "build*" in the gitignore, so I can't add build.sh to an AArch64 folder.. So now I have to add a redundant aarch64-build.sh in the aarch64 folder..

This does not sound right. There are build.sh/build.bat files sitting in .github/automation.

@theComputeKid
Copy link
Member Author

@vpirogov : I think the "build*" edit to gitignore was made after the scripts were already in. But no worries, I changed it to "/build*" and now it will only match build* folders in root, which is what we want.

@theComputeKid
Copy link
Member Author

@vpirogov : 41c2804
Here we go.

@theComputeKid theComputeKid force-pushed the theComputeKid/ci branch 2 times, most recently from 90e0bd7 to c5e72c5 Compare February 6, 2025 16:51
@vpirogov
Copy link
Member

vpirogov commented Feb 6, 2025

@vpirogov : I think the "build*" edit to gitignore was made after the scripts were already in. But no worries, I changed it to "/build*" and now it will only match build* folders in root, which is what we want.

My git (2.40.1) still does not bark at new files with 'build' in the name. But your fix makes sense based on .gitignore documentation.

@theComputeKid theComputeKid marked this pull request as ready for review February 6, 2025 21:55
@theComputeKid theComputeKid requested review from a team as code owners February 6, 2025 21:55
@theComputeKid
Copy link
Member Author

@vpirogov : ready.

@vpirogov
Copy link
Member

vpirogov commented Feb 6, 2025

Do you want to update x64 CI trigger as part of this PR as well?

@theComputeKid theComputeKid force-pushed the theComputeKid/ci branch 9 times, most recently from 532c1cf to c5e72c5 Compare February 7, 2025 03:11
@theComputeKid theComputeKid merged commit 02b33c1 into main Feb 7, 2025
24 checks passed
@theComputeKid theComputeKid deleted the theComputeKid/ci branch February 7, 2025 14:28
@theComputeKid
Copy link
Member Author

@vpirogov : I tried many (10) times and still couldn't get Azure to skip, so I gave up. Could you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Github automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants