Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpu: generic: skip unimplemented cases #2614

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sgeor255
Copy link
Contributor

@sgeor255 sgeor255 commented Feb 6, 2025

Description

Currently, when running benchdnn tests on the generic SYCL backend, unimplemented cases are reported as failures. This makes it challenging to identify actual failures. It also clutters the CI logs with false-positive failure reports. Furthermore, the generic implementations are still under development, and there are several known limitations (e.g., lack of blocked format support) that should not be flagged as errors. For instance, the reorder issue reported in MFDNN-13088 currently appears as a failing test, but it is actually due to unsupported features like blocked formats and zero-points. This PR changes the status of such tests to SKIPPED, as is done with the NVIDIA and AMD backends, to prevent them from being reported as failures.

Checklist

General

  • Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit?
  • Have you formatted the code using clang-format?

@sgeor255 sgeor255 requested a review from a team as a code owner February 6, 2025 15:29
@github-actions github-actions bot added the component:tests Codeowner: @oneapi-src/onednn-arch label Feb 6, 2025
Copy link
Contributor

@Rbiessy Rbiessy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I believe this would help us prioritize issues that are bugs instead of missing features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:tests Codeowner: @oneapi-src/onednn-arch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants