Handle large strides in matmul properly #2611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
platform:cpu-x64
|
make test |
densamoilov
changed the title
xuxinzen
approved these changes
Feb 6, 2025
ankalinin
approved these changes
Feb 6, 2025
amakarev
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes MFDNN-13075.
This PR adds checks for large (> INT32_MAX) strides to brgemm-based matmul primitive so that such cases can be properly handled by returning an "unimplemented".
Adding support for large strides will require extending brgemm and copy routines which doesn't seem to be a good investment at this point because the shapes are not used in real world workloads for CPU.