Regression ci #2350
Closed
Regression ci #2350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryo-not-rio
force-pushed
the
regression-ci
branch
2 times, most recently
from
d706bf9 to
db2314c
Compare
Ryo-not-rio
force-pushed
the
regression-ci
branch
from
f54c047 to
83b5daa
Compare
|
Changing this to draft so we don't annoy the rest of the world by tagging the reviewers. You should be able to continue working on it as usual pushing to the draft PRs and the github actions will still run. |
jondea
reviewed
Jan 8, 2025
| runs-on: ${{ matrix.config.label }} | ||
| steps: | ||
|
|
||
| - name: Checkout oneDNN |
There was a problem hiding this comment.
I worry about replicating all this oneDNN building logic. Can we not have a common build oneDNN pipeline and use the artifacts from it to test or benchmark?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a regression test ci to compare a PR against the main branch