Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu: aarch64: make softmax ops use stateless ACL interface #2136

Merged
merged 3 commits into from
Oct 21, 2024
Merged

cpu: aarch64: make softmax ops use stateless ACL interface #2136

merged 3 commits into from
Oct 21, 2024

Conversation

taoye9
Copy link
Contributor

@taoye9 taoye9 commented Sep 30, 2024 •
edited
Loading

Description

To change arm aarch64 softmax api from stateful to stateless.
This PR requires ACL 24.09.

Checklist

General

  • Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit?
  • Have you formatted the code using clang-format?

@taoye9 taoye9 requested a review from a team as a code owner September 30, 2024 14:47
@theComputeKid
Copy link
Member

theComputeKid commented Sep 30, 2024 •
edited
Loading

Some extra changes need to be made:

  1. We need to update the minimum version in the doc README.
  2. And also update the min version in FindACL.cmake.
  3. Rebase

@mgouicem mgouicem added the platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64 label Oct 9, 2024
@taoye9 taoye9 force-pushed the feat-stateless-softmax branch from 13d942e to 8549523 Compare October 15, 2024 11:55
@taoye9 taoye9 requested review from a team as code owners October 15, 2024 11:55
@taoye9 taoye9 force-pushed the feat-stateless-softmax branch from 8549523 to a202098 Compare October 15, 2024 11:57
ranukund
ranukund approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@ranukund ranukund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

mgouicem
mgouicem approved these changes Oct 17, 2024
View reviewed changes
src/cpu/aarch64/acl_softmax.cpp Outdated Show resolved Hide resolved
src/cpu/aarch64/acl_softmax.cpp Outdated Show resolved Hide resolved
@taoye9 taoye9 force-pushed the feat-stateless-softmax branch from 25f95f9 to fca8b85 Compare October 17, 2024 15:48
@mgouicem mgouicem merged commit f56ebe4 into oneapi-src:main Oct 21, 2024
14 of 17 checks passed
@theComputeKid
Copy link
Member

The change made here (#2136 (comment)) has diverted calls from acl to ref. @taoye9 can you please take a look.

@taoye9 taoye9 mentioned this pull request Oct 22, 2024
Merged
2 tasks
@vpirogov vpirogov added this to the v3.7 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theComputeKid theComputeKid theComputeKid approved these changes

@mgouicem mgouicem mgouicem approved these changes

@ranukund ranukund ranukund approved these changes

Assignees
No one assigned
Labels
platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64
Projects
None yet
Milestone
v3.7
Development

Successfully merging this pull request may close these issues.
5 participants
@taoye9 @theComputeKid @mgouicem @ranukund @vpirogov