sycl: update documentation #2129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
densamoilov
reviewed
Sep 27, 2024
densamoilov
reviewed
Sep 27, 2024
sgeor255
force-pushed
the
svet/update-sycl-docs
branch
from
1a2a009 to
9c50b89
Compare
densamoilov
approved these changes
Oct 3, 2024
mgouicem
approved these changes
Oct 4, 2024
ranukund
reviewed
Oct 4, 2024
src/gpu/generic/sycl/README.md
Outdated
| General limitations: | ||
|
|
||
| * Currently blocked formats are not supported by any implementation unless | ||
| explicitly listed |
There was a problem hiding this comment.
It seems there's an extra space here.
src/gpu/generic/sycl/README.md
Outdated
| @@ -33,11 +33,56 @@ one, the environment variable can be set to `cuda:*`. | |||
|
|
|||
| # Supported Primitives | |||
|
|
|||
| General limitations: | |||
|
|
|||
| * Currently blocked formats are not supported by any implementation unless | |||
There was a problem hiding this comment.
Suggested change
| * Currently blocked formats are not supported by any implementation unless | |
| * Currently blocked formats are not supported by any implementations unless |
src/gpu/generic/sycl/README.md
Outdated
| ## Batch Normalization | ||
|
|
||
| The implementation supports both forward and backward directions. | ||
|
|
||
| * Supported formats: `NCDHW`, `NDHWC`, `NCHW`, `NHWC`, `NCW`, `NWC`, `NC` | ||
| * Supported data types |
There was a problem hiding this comment.
Suggested change
| * Supported data types | |
| * Supported data types: |
src/gpu/generic/sycl/README.md
Outdated
|
|
||
| ## Convolution | ||
|
|
||
| The implementation supports forward, backward data and backward weights |
There was a problem hiding this comment.
Suggested change
| The implementation supports forward, backward data and backward weights | |
| The implementation supports forward data, backward data, and backward weight |
src/gpu/generic/sycl/README.md
Outdated
| directions. | ||
|
|
||
| * Supported input/output formats: plain formats | ||
| * Supported weights formats: `goiw`, `goihw`, `goidhw`, `oiw`, `oihw`, `oidhw`; |
There was a problem hiding this comment.
Suggested change
| * Supported weights formats: `goiw`, `goihw`, `goidhw`, `oiw`, `oihw`, `oidhw`; | |
| * Supported weights formats: `goiw`, `goihw`, `goidhw`, `oiw`, `oihw`, `oidhw` |
| * Supported weights formats: `goiw`, `goihw`, `goidhw`, `oiw`, `oihw`, `oidhw`; | ||
| * Supported data types: `f32`, `bf16`, `f16`, `s32`, `s8`, `u8` | ||
| * Limitations | ||
| * Some very large problem sizes currently return `unimplemented` due to an |
There was a problem hiding this comment.
Suggested change
| * Some very large problem sizes currently return `unimplemented` due to an | |
| * Few substantial problem sizes currently return `unimplemented` due to an |
src/gpu/generic/sycl/README.md
Outdated
| directions. | ||
|
|
||
| * Supported input/output formats: plain formats | ||
| * Supported weights formats: `goiw`, `goihw`, `goidhw`, `oiw`, `oihw`, `oidhw`; |
There was a problem hiding this comment.
Suggested change
| * Supported weights formats: `goiw`, `goihw`, `goidhw`, `oiw`, `oihw`, `oidhw`; | |
| * Supported weights formats: `goiw`, `goihw`, `goidhw`, `oiw`, `oihw`, `oidhw` |
src/gpu/generic/sycl/README.md
Outdated
| * Supported weights formats: `goiw`, `goihw`, `goidhw`, `oiw`, `oihw`, `oidhw`; | ||
| * Supported data types: `f32`, `bf16`, `f16`, `s32`, `s8`, `u8` | ||
| * Limitations | ||
| * Some very large problem sizes currently return `unimplemented` due to an |
There was a problem hiding this comment.
Suggested change
| * Some very large problem sizes currently return `unimplemented` due to an | |
| * Few substantial problem sizes currently return `unimplemented` due to an |
src/gpu/generic/sycl/README.md
Outdated
|
|
||
| ## Pooling | ||
|
|
||
| The implementation supports both forward and backward directions. | ||
|
|
||
| * Supported formats: `NCDHW`, `NDHWC`, `NCHW`, `NHWC`, `NCW`, `NWC` | ||
| * Supported data types for forward direction: f32, bf16, f16, s8, u8 |
There was a problem hiding this comment.
Suggested change
| * Supported data types for forward direction: f32, bf16, f16, s8, u8 | |
| * Supported data types for forward direction: `f32`, `bf16`, `f16`, `s8`, `u8` |
src/gpu/generic/sycl/README.md
Outdated
|
|
||
| ## Pooling | ||
|
|
||
| The implementation supports both forward and backward directions. | ||
|
|
||
| * Supported formats: `NCDHW`, `NDHWC`, `NCHW`, `NHWC`, `NCW`, `NWC` | ||
| * Supported data types for forward direction: f32, bf16, f16, s8, u8 | ||
| * Supported data types for backward direction: f32, bf16, f16 |
There was a problem hiding this comment.
Suggested change
| * Supported data types for backward direction: f32, bf16, f16 | |
| * Supported data types for backward direction: `f32`, `bf16`, `f16` |
ranukund
approved these changes
Oct 4, 2024
sgeor255
force-pushed
the
svet/update-sycl-docs
branch
from
9c50b89 to
93b7bd8
Compare
Thanks, @ranukund , I have made most of the suggested changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the documentation about SYCL primitives.