Add files via upload#1592
Closed
bjodom wants to merge 1 commit intooneapi-src:developmentfrom
bjodom:mkl
Closed
Conversation
Contributor
|
Adding @tomlenth @jkinsky |
Contributor
|
@jimmytwei yes, it should go into oneMKL and follow a structure that includes the README such as this: sycl-performance-portability-training. This includes supporting files, and naming conventions of both the directory and .py files. |
|
Yes. We should have a readme for all samples. Tom's suggestions for an example works. |
|
@jimmytwei and @bjodom - Should this also have a sample.json file? |
ghost
approved these changes
Apr 28, 2023
Contributor
|
@jkinsky @bjodom Yes, it should if we want it to be picked up by the samples aggregator and the CI for automated testing. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing Sample Changes
Description
These are an update and new addition to the oneAPI samples repo. This is a cleaned up and updated oneMKL example that uses jupyter and demonstrates oneMKL with buffers/accessors, USM, and MPI. While not part of the samples it has been used as an MKL learning path for a year.
Fixes Issue#
External Dependencies
None
Type of change
Please delete options that are not relevant. Add a 'X' to the one that is applicable.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration