[External Resource Interop][Semaphores] Added support for 2 more semaphore types #2751
+244
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziranzha
reviewed
Mar 31, 2025
| if (extSemType == sycl::ext::oneapi::experimental:: | ||
| external_semaphore_handle_type::win32_nt_dx12_fence) { | ||
| q_ptr->ext_oneapi_signal_external_semaphore( | ||
| case sycl::ext::oneapi::experimental::external_semaphore_handle_type:: |
There was a problem hiding this comment.
Can be merge WIN32 together?
There was a problem hiding this comment.
Okay, I'll refactor the switch case
ziranzha
reviewed
Mar 31, 2025
| @@ -1550,6 +1550,18 @@ void MapNames::setExplicitNamespaceMap( | |||
| ? getExpNamespace() + | |||
| "external_semaphore_handle_type::win32_nt_dx12_fence" | |||
| : "cudaExternalSemaphoreHandleTypeD3D12Fence")}, | |||
| {"cudaExternalSemaphoreHandleTypeTimelineSemaphoreFd", | |||
There was a problem hiding this comment.
The migration for cudaExternalSemaphoreHandleTypeTimelineSemaphoreFd is external_semaphore_handle_type::timeline_fd here
|
The case passes locally using latest xmain-rel compiler
|
zhiweij1
pushed a commit
to zhiweij1/SYCLomatic
that referenced
this pull request
Apr 8, 2025
|
Closing the PR due to CI issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for 2 more Semaphore types:
As well as adds all the external resource interop APIs to QAP test case