Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise CSV export by saving columns #2762

Merged
merged 19 commits into from
Jan 28, 2025
Merged

Conversation

kelvin-muchiri
Copy link
Contributor

@kelvin-muchiri kelvin-muchiri commented Jan 17, 2025

Changes / Features implemented

Build and save CSV export columns after an Instance is saved. The previous optimisation technique saved the maximum number for each repeat group. This resulted in extra columns for submissions with less repeats than the maximum.

Steps taken to verify this change does what is intended

  • QA

Side effects of implementing this change

No extra columns in the CSV for records where a repeat group number is less than the maximum number

Before submitting this PR for review, please make sure you have:

  • Included tests
  • Updated documentation

Closes #

@kelvin-muchiri kelvin-muchiri force-pushed the csv-export-save-columns branch from 6fbd74c to c2c4644 Compare January 21, 2025 07:32
@kelvin-muchiri kelvin-muchiri force-pushed the csv-export-save-columns branch from aca8dee to 8359e4a Compare January 23, 2025 12:33
@kelvin-muchiri kelvin-muchiri marked this pull request as ready for review January 27, 2025 10:02
@kelvin-muchiri kelvin-muchiri merged commit f911be9 into main Jan 28, 2025
10 checks passed
@kelvin-muchiri kelvin-muchiri deleted the csv-export-save-columns branch January 28, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants