Process Instance metadata from light tasks synchronously #2547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the asynchronous task to update Instance.json with the full dict gets delayed, _id will be missing from the data. The change ensures even if async processing is enabled, non-performance intensive Instance.json data are always save asynchronously
kelvin-muchiri
changed the title
kelvin-muchiri
requested review from
FrankApiyo,
KipSigei,
ciremusyoka and
bobbyqiz448
KipSigei
approved these changes
Jan 29, 2024
bobbyqiz448
approved these changes
Jan 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Always process metadata from light tasks synchronously regardless of whether
ASYNC_POST_SUBMISSION_PROCESSING_ENABLEDis enabled or not.Steps taken to verify this change does what is intended
Side effects of implementing this change
Before submitting this PR for review, please make sure you have:
Closes #2548