Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log auth details #2479

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Log auth details #2479

wants to merge 4 commits into from
+57 −8

Conversation

KipSigei
Copy link
Contributor

@KipSigei KipSigei commented Sep 18, 2023 •
edited
Loading

Changes / Features implemented

  • Log auth details i.e username, ip, user agent and remaining login attempts for a user during authentication failures

Steps taken to verify this change does what is intended

  • Added tests

Side effects of implementing this change

  • Auth logs will be persisted to a file as well as sentry

Before submitting this PR for review, please make sure you have:

  • Included tests
  • Updated documentation

Closes #

@KipSigei KipSigei force-pushed the add-auth-logging branch 4 times, most recently from a4f6e25 to 4822d6f Compare September 18, 2023 15:09
@KipSigei
Log auth details
98900cf 
Signed-off-by: Kipchirchir Sigei <[email protected]>
@KipSigei
Log auth details during debugging
eb47c30 
Signed-off-by: Kipchirchir Sigei <[email protected]>
@KipSigei
Add tests
4ced17a 
Signed-off-by: Kipchirchir Sigei <[email protected]>
@KipSigei KipSigei force-pushed the add-auth-logging branch 2 times, most recently from bfeb19a to 52b187c Compare September 26, 2023 14:06
@KipSigei
Add auth debug logging configs
541a978 
Signed-off-by: Kipchirchir Sigei <[email protected]>
@KipSigei KipSigei force-pushed the add-auth-logging branch 2 times, most recently from c6a251c to 541a978 Compare September 27, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelvin-muchiri kelvin-muchiri kelvin-muchiri left review comments

@ukanga ukanga ukanga left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KipSigei @ukanga @kelvin-muchiri