Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all locations list view submenu #1340

Merged
merged 21 commits into from
Mar 12, 2024

Conversation

bobbyqiz448
Copy link
Contributor

@bobbyqiz448 bobbyqiz448 commented Feb 25, 2024

closes #1331

Include option for flat listing of locations instead of hierarchical

Changes included with this PR

Checklist

  • tests are included and passing
  • documentation is changed or added
  • Internationalization:
    • Ensure all strings are internationalized.
  • Role-Based Access:
    • Verify that all user actions have appropriate role-based access permissions set.

Sorry, something went wrong.

@bobbyqiz448 bobbyqiz448 force-pushed the add-all-locations-list-view-submenu branch from b794ff0 to af9955f Compare February 28, 2024 14:13
@ciremusyoka ciremusyoka force-pushed the add-all-locations-list-view-submenu branch from d49601e to 4d52dc8 Compare March 5, 2024 07:12
@ciremusyoka ciremusyoka force-pushed the add-all-locations-list-view-submenu branch from 2ed12af to 17c8786 Compare March 6, 2024 06:55
Copy link
Contributor

@peterMuriuki peterMuriuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ciremusyoka When I tested this branch. I noticed

  1. Last table pagination pages do not have data, I have 5 recs per page. It seems to be something to do with the queryParams encoding, but let me know if this also happens on your end. e.g this does not yield results in the entry but this does

Comment on lines 142 to 155
const getTableLocale = () => {
const urlQuery = history.location.search;
const nameSearchActive = urlQuery.includes('search=');
if (!tableData.length && (!isFetching || !isLoading)) {
const description = nameSearchActive
? ''
: t('No data available to display, you can start adding data now ');
return {
emptyText: (
<NoData description={description}>{!nameSearchActive && <AddLocationBtn />}</NoData>
),
};
}
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏿

<Helmet>
<title>{t('All Locations List')}</title>
</Helmet>
<PageHeader title={t('All Locations Flat')} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change title to All Locations

@ciremusyoka ciremusyoka force-pushed the add-all-locations-list-view-submenu branch from 5e5bf3d to 663ad16 Compare March 7, 2024 15:05
@peterMuriuki peterMuriuki merged commit a002dc1 into main Mar 12, 2024
0 of 2 checks passed
@peterMuriuki peterMuriuki deleted the add-all-locations-list-view-submenu branch March 12, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EUSM] All locations list view
3 participants