Enable python 3.12, 3.13 (#1203)

omry · Jan 19, 2025 · 117f7de · 117f7de
1 parent d61b588
commit 117f7de
Show file tree

Hide file tree

Showing 9 changed files with 16 additions and 14 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -39,4 +39,4 @@ workflows:
       - test_linux:
           matrix:
             parameters:
-              py_version: ["3.8", "3.9", "3.10", "3.11"]
+              py_version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
diff --git a/noxfile.py b/noxfile.py
@@ -4,7 +4,7 @@
 import nox
 from nox import Session
 
-DEFAULT_PYTHON_VERSIONS = ["3.8", "3.9", "3.10", "3.11"]
+DEFAULT_PYTHON_VERSIONS = ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
 
 PYTHON_VERSIONS = os.environ.get(
     "NOX_PYTHON_VERSIONS", ",".join(DEFAULT_PYTHON_VERSIONS)

diff --git a/omegaconf/_utils.py b/omegaconf/_utils.py
@@ -350,7 +350,7 @@ def get_attr_data(obj: Any, allow_objects: Optional[bool] = None) -> Dict[str, A
                 value = MISSING
         if is_union_annotation(type_) and not is_supported_union_annotation(type_):
             e = ConfigValueError(
-                f"Unions of containers are not supported:\n{name}: {type_str(type_)}"
+                f"Unions of containers are not supported:\n{name}: {type_str(type_)}"  # noqa: E231
             )
             format_and_raise(node=None, key=None, value=value, cause=e, msg=str(e))
 
@@ -409,7 +409,7 @@ def get_dataclass_data(
 
         if is_union_annotation(type_) and not is_supported_union_annotation(type_):
             e = ConfigValueError(
-                f"Unions of containers are not supported:\n{name}: {type_str(type_)}"
+                f"Unions of containers are not supported:\n{name}: {type_str(type_)}"  # noqa: E231
             )
             format_and_raise(node=None, key=None, value=value, cause=e, msg=str(e))
         try:

diff --git a/omegaconf/basecontainer.py b/omegaconf/basecontainer.py
@@ -738,9 +738,9 @@ def _get_full_key(self, key: Union[DictKeyType, int, slice, None]) -> str:
 
         def _slice_to_str(x: slice) -> str:
             if x.step is not None:
-                return f"{x.start}:{x.stop}:{x.step}"
+                return f"{x.start}:{x.stop}:{x.step}"  # noqa: E231
             else:
-                return f"{x.start}:{x.stop}"
+                return f"{x.start}:{x.stop}"  # noqa: E231
 
         def prepand(
             full_key: str,

diff --git a/omegaconf/grammar_parser.py b/omegaconf/grammar_parser.py
@@ -28,8 +28,10 @@
 _id = "[a-zA-Z_][\\w\\-]*"  # foo, foo_bar, foo-bar, abc123
 _resolver_name = f"({_id}(\\.{_id})*)?"  # foo, ns.bar3, ns_1.ns_2.b0z
 _arg = r"[a-zA-Z_0-9/\-\+.$%*@?|]+"  # string representing a resolver argument
-_args = f"{_arg}(\\s*,\\s*{_arg})*"  # list of resolver arguments
-_resolver_inter = f"\\${{\\s*{_resolver_name}\\s*:\\s*{_args}?\\s*}}"  # ${foo:bar}
+_args = f"{_arg}(\\s*,\\s*{_arg})*"  # list of resolver arguments  # noqa: E231
+_resolver_inter = (
+    f"\\${{\\s*{_resolver_name}\\s*:\\s*{_args}?\\s*}}"  # ${foo:bar}  # noqa: E231
+)
 _inter = f"({_node_inter}|{_resolver_inter})"  # any kind of interpolation
 _outer = "([^$]|\\$(?!{))+"  # any character except $ (unless not followed by {)
 SIMPLE_INTERPOLATION_PATTERN = re.compile(

diff --git a/omegaconf/grammar_visitor.py b/omegaconf/grammar_visitor.py
@@ -251,7 +251,7 @@ def empty_str_warning() -> None:
             warnings.warn(
                 f"In the sequence `{txt}` some elements are missing: please replace "
                 f"them with empty quoted strings. "
-                f"See https://github.com/omry/omegaconf/issues/572 for details.",
+                f"See https://github.com/omry/omegaconf/issues/572 for details.",  # noqa: E231
                 category=UserWarning,
             )
 

diff --git a/omegaconf/omegaconf.py b/omegaconf/omegaconf.py
@@ -372,7 +372,7 @@ def resolver_wrapper(
                     f"to be an interpolation. Nested interpolations are not supported for "
                     f"resolvers registered with `[legacy_]register_resolver()`, please use "
                     f"`register_new_resolver()` instead (see "
-                    f"https://github.com/omry/omegaconf/issues/426 for migration instructions)."
+                    f"https://github.com/omry/omegaconf/issues/426 for migration instructions)."  # noqa: E231
                 )
             key = args_str
             val = cache[key] if key in cache else resolver(*args_unesc)

diff --git a/tests/interpolation/built_in_resolvers/test_oc_decode.py b/tests/interpolation/built_in_resolvers/test_oc_decode.py
@@ -49,7 +49,7 @@ def test_decode(monkeypatch: Any, value: Optional[str], expected: Any) -> None:
         {
             # The node of interest is "node" (others are used to test interpolations).
             "parent": {
-                "node": f"${{oc.decode:'{value}'}}",
+                "node": f"${{oc.decode:'{value}'}}",  # noqa: E231
                 "sibling": 1,
             },
             "uncle": 2,
@@ -100,6 +100,6 @@ def test_decode_none() -> None:
     ],
 )
 def test_decode_error(monkeypatch: Any, value: Any, exc: Any) -> None:
-    c = OmegaConf.create({"x": f"${{oc.decode:{value}}}"})
+    c = OmegaConf.create({"x": f"${{oc.decode:{value}}}"})  # noqa: E231
     with exc:
         c.x
diff --git a/tests/test_grammar.py b/tests/test_grammar.py
@@ -191,9 +191,9 @@
     ),
     (
         "dict_unquoted_key",
-        rf"{{a0-null-1-3.14-NaN- {TAB}-true-False-{UNQUOTED_SPECIAL}\(\)\[\]\{{\}}\:\=\ \{TAB}\,:0}}",
+        rf"{{a0-null-1-3.14-NaN- {TAB}-true-False-{UNQUOTED_SPECIAL}\(\)\[\]\{{\}}\:\=\ \{TAB}\,:0}}",  # noqa: E231
         {
-            rf"a0-null-1-3.14-NaN- {TAB}-true-False-{UNQUOTED_SPECIAL}()[]{{}}:= {TAB},": 0
+            rf"a0-null-1-3.14-NaN- {TAB}-true-False-{UNQUOTED_SPECIAL}()[]{{}}:= {TAB},": 0  # noqa: E231
         },
     ),
     (