Skip to content

Commit

Permalink
Merge pull request #4466 from omnivore-app/jacksonh/disable-posthog
Browse files Browse the repository at this point in the history
Disable posthog
  • Loading branch information
jacksonh authored Oct 31, 2024
2 parents c5343b1 + e53a3ad commit ccaccab
Show file tree
Hide file tree
Showing 8 changed files with 12 additions and 67 deletions.
23 changes: 11 additions & 12 deletions packages/api/src/utils/analytics.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,18 +21,17 @@ class PostHogClient implements AnalyticClient {
}

capture({ distinctId, event, properties }: AnalyticEvent) {
// get client from request context
const client = httpContext.get<string>('client') || 'other'

this.client.capture({
distinctId,
event,
properties: {
...properties,
client,
env: env.server.apiEnv,
},
})
// // get client from request context
// const client = httpContext.get<string>('client') || 'other'
// this.client.capture({
// distinctId,
// event,
// properties: {
// ...properties,
// client,
// env: env.server.apiEnv,
// },
// })
}

async shutdownAsync() {
Expand Down
24 changes: 1 addition & 23 deletions packages/web/lib/analytics.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { UserBasicData } from './networking/queries/useGetViewerQuery'
import { intercomAppID, posthogApiKey, webBaseURL } from './appConfig'
import posthog from 'posthog-js'
import { intercomAppID } from './appConfig'

const userInfo = (
user: UserBasicData
Expand All @@ -19,17 +18,6 @@ const initAnalytics = (user?: UserBasicData): void => {
vertical_padding: 120,
custom_launcher_selector: '.custom-intercom-launcher',
}
if (posthogApiKey) {
posthog.init(posthogApiKey, {
api_host: `${webBaseURL}/collect`,
autocapture: false,
person_profiles: 'identified_only',
disable_session_recording: false,
advanced_disable_decide: true,
advanced_disable_feature_flags: true,
advanced_disable_toolbar_metrics: true,
})
}
if (user) {
window.Intercom('boot', userInfo(user))
}
Expand All @@ -46,15 +34,5 @@ export const setupAnalytics = (user?: UserBasicData): void => {

if (user) {
window.Intercom('update', userInfo(user))
posthog.identify(user.id, {
name: user.name,
username: user.profile.username,
})
}
}

export const deinitAnalytics = (): void => {
if (posthog && posthogApiKey) {
posthog.reset(true)
}
}
2 changes: 0 additions & 2 deletions packages/web/lib/appConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,6 @@ export const appleAuthRedirectURI =

export const intercomAppID = process.env.NEXT_PUBLIC_INTERCOM_APP_ID

export const posthogApiKey = process.env.NEXT_PUBLIC_POSTHOG_API_KEY

export const googleID =
appEnv == 'prod'
? process.env.NEXT_PUBLIC_GOOGLE_ID
Expand Down
2 changes: 0 additions & 2 deletions packages/web/lib/logout.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { useQueryClient } from '@tanstack/react-query'
import { deinitAnalytics } from './analytics'
import { logoutMutation } from './networking/mutations/logoutMutation'
import { useCallback } from 'react'
import { useRouter } from 'next/router'
Expand All @@ -14,7 +13,6 @@ export const useLogout = () => {
if (!result) {
throw new Error('Logout failed')
}
deinitAnalytics()
queryClient.clear()
console.log('cleared the query client')
router.push('/login')
Expand Down
4 changes: 0 additions & 4 deletions packages/web/next.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,6 @@ const moduleExports = {
}
)
}
rewrites.push({
source: '/collect/:match*',
destination: 'https://app.posthog.com/:match*',
})
rewrites.push({
source: '/home',
destination: '/l/home',
Expand Down
1 change: 0 additions & 1 deletion packages/web/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@
"next": "^13.5.6",
"node-html-markdown": "^1.3.0",
"papaparse": "^5.4.1",
"posthog-js": "^1.158.3",
"pspdfkit": "^2023.4.6",
"re-resizable": "^6.9.11",
"react": "^18.2.0",
Expand Down
12 changes: 0 additions & 12 deletions packages/web/pages/[username]/[slug]/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import { VerticalArticleActionsMenu } from '../../../components/templates/articl
import { PdfHeaderSpacer } from '../../../components/templates/article/PdfHeaderSpacer'
import { EpubContainerProps } from '../../../components/templates/article/EpubContainer'
import { useSetPageLabels } from '../../../lib/hooks/useSetPageLabels'
import { posthog } from 'posthog-js'
import { PDFDisplaySettingsModal } from '../../../components/templates/article/PDFDisplaySettingsModal'
import {
ArticleReadingProgressMutationInput,
Expand Down Expand Up @@ -270,17 +269,6 @@ export default function Reader(): JSX.Element {
}
}, [actionHandler, goNextOrHome, goPreviousOrHome])

useEffect(() => {
if (libraryItem && viewerData) {
posthog.capture('link_read', {
link: libraryItem.id,
slug: libraryItem.slug,
reader: libraryItem.contentReader,
url: libraryItem.originalArticleUrl,
})
}
}, [libraryItem, viewerData])

useRegisterActions(
[
{
Expand Down
11 changes: 0 additions & 11 deletions packages/web/pages/_app.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import {
} from '../components/elements/KBar'
import { updateTheme } from '../lib/themeUpdater'
import { ThemeId } from '../components/tokens/stitches.config'
import { posthog } from 'posthog-js'
import { GoogleReCaptchaProvider } from '@google-recaptcha/react'
import AsyncStorage from '@react-native-async-storage/async-storage'
import { QueryClient } from '@tanstack/react-query'
Expand Down Expand Up @@ -96,16 +95,6 @@ const ConditionalCaptchaProvider = (props: {
export function OmnivoreApp({ Component, pageProps }: AppProps): JSX.Element {
const router = useRouter()

useEffect(() => {
const handleRouteChange = (url: string) => {
posthog.capture('$pageview')
}
router.events.on('routeChangeComplete', handleRouteChange)
return () => {
router.events.off('routeChangeComplete', handleRouteChange)
}
}, [router.events])

return (
<ConditionalCaptchaProvider>
<Toaster />
Expand Down

0 comments on commit ccaccab

Please sign in to comment.