Migrate panel resize to pointer events - #4784
Closed
btli wants to merge 10 commits into
Closed
Conversation
Signed-off-by: Bryan Li <bryan.li@gmail.com>
Signed-off-by: Bryan Li <bryan.li@gmail.com>
Signed-off-by: Bryan Li <bryan.li@gmail.com>
btli
pushed a commit
to btli/omnigent
that referenced
this pull request
Aug 14, 2026
Signed-off-by: Bryan Li <bryan.li@gmail.com>
Signed-off-by: Bryan Li <bryan.li@gmail.com>
Signed-off-by: Bryan Li <bryan.li@gmail.com>
Signed-off-by: Bryan Li <bryan.li@gmail.com>
Contributor
Author
|
Tribunal attestation (automated multi-engine review): CLEAN Both blocking engines (codex + claude_code) attested head |
This was referenced Aug 14, 2026
btli
marked this pull request as ready for review
August 14, 2026 15:53
Signed-off-by: Bryan Li <bryan.li@gmail.com>
Signed-off-by: Bryan Li <bryan.li@gmail.com>
Signed-off-by: Bryan Li <bryan.li@gmail.com>
Contributor
|
Closed. If you want to pick this back up, comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4790
Related issue
N/A — implements TR-6, TR-7, and TR-9 from the touch interaction specification.
Summary
useResizablePanelfrom window-level mouse events to captured pointer events so mouse, touch, and pen resize the shared right-side panels.touch-action: noneplus an invisible 44px cross-axis hit target entirely throughhandleProps, without consumer changes.ELI5: The resize strip now holds onto the first finger or stylus that grabs it, keeps receiving movement even when the pointer crosses other content, and lets go safely if the browser cancels the gesture.
Test Plan
npx -y -p node@22 -p pnpm@11.15.1 -c 'node --version && pnpm --version && pnpm install --frozen-lockfile'cd web && npx -y -p node@22 -c './node_modules/.bin/vitest run src/hooks/useResizablePanel.test.tsx && ./node_modules/.bin/tsc -b'pyrefly, which discovered zero Python files because this worktree lives under the parent repo's ignored.worktreesdirectory.Demo
Workspace-panel seam touch-drag validated live on foldable and tablet — smooth tracking, clamps, persistence; adjacent content scroll unaffected.
Type of change
Test coverage
Coverage notes
Focused hook tests cover pointer capture and release, cancellation, capture loss, concurrent pointer arbitration, persistence timing, and returned touch affordances.
Changelog
Resize right-side panels with touch or a stylus using a larger, easier-to-grab handle.