fix(web): use opaque background for maximized workspace panel - #4376

Polly AI Review

Review: fix(web): use opaque background for maximized workspace panel

Blocking issues

None. The fix is correct and well-scoped:

• data-maximized={maximized || undefined} correctly renders the attribute only when maximized (true → present, undefined → omitted), so the [data-maximized] / :not([data-maximized]) attribute selectors gate exactly as intended.
• --card-solid is defined in every theme scope that can be active (default light/dark, custom translucent light/dark, and all built-in themes), so var(--card-solid) always resolves to an opaque value — no undefined-variable fallback risk.
• The :not([data-maximized]) guard is applied consistently to all three transparent/translucent docked rules (the base dark rule and both custom-translucent-sidebar media rules), so nothing re-introduces transparency in the maximized state. When maximized, the panel-content children revert to their default bg-card fills, but the opaque --card-solid on the <aside> sits behind them, preventing bleed-through even if --card is semi-transparent.
• Specificity/!important interplay is sound: the docked transparent rules are excluded via :not([data-maximized]) when maximized, so the single maximized !important rule wins uncontested.

Security vulnerabilities

None. CSS-only change plus one boolean-derived data attribute; no injection, auth, or data-exposure surface.

Non-blocking notes

• The maximized opaque rule applies across all themes, including light mode where the docked panel already uses md:bg-card. This is harmless (still opaque and theme-consistent) and arguably more robust, but note the fix is not strictly dark-mode-only despite the PR framing.
• No automated coverage, as acknowledged. Glassmorphism/theme rendering is inherently visual; manual verification is a reasonable bar here, though a lightweight snapshot asserting data-maximized toggles on the aside would guard the React side of the contract against regression.

Summary

A clean, correct, minimal fix. The transparent-background rule is properly gated to the docked state and an opaque --card-solid backing is applied when maximized, resolving the bleed-through across all themes. No correctness or security concerns; ship it.

_{Automated review by Polly · workflow run}

🏷️ Doc impact: no-doc-update

This is a purely visual CSS/styling fix giving the maximized workspace panel an opaque background so chat content doesn't bleed through — no user-facing feature, integration, policy, or documented behavior changed.

_{Auto-classified on merge. Set the label manually before merging to override. · run}