fix(web): use opaque background for maximized workspace panel - #4376
Open
terrytangyuan wants to merge 1 commit into
Open
fix(web): use opaque background for maximized workspace panel#4376terrytangyuan wants to merge 1 commit into
terrytangyuan wants to merge 1 commit into
Conversation
terrytangyuan
force-pushed
the
fix/fullscreen
branch
from
August 7, 2026 19:59
73d539a to
2231b72
Compare
The dark-mode glassmorphism rule clears the workspace panel's background to transparent so it blends into the canvas when docked. When the panel is maximized (absolute inset-0), this lets the chat content underneath bleed through. Add a data-maximized attribute to the panel and gate the transparent background rules with :not([data-maximized]). Apply an explicit var(--card-solid) background when maximized so the panel is opaque across all themes. Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
terrytangyuan
force-pushed
the
fix/fullscreen
branch
from
August 8, 2026 01:54
2231b72 to
f03439f
Compare
github-actions
Bot
added
size/S
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
N/A
Summary
In dark mode, the workspace panel's background is set to
transparentso it blends into the canvas when docked. When the panel is maximized (fullscreen mode for viewing code changes), it usesabsolute inset-0to cover the full content area — but the transparent background lets the chat content underneath bleed through.This fix:
data-maximizedattribute to the workspace panel<aside>when maximized.:not([data-maximized])so it only applies when docked.var(--card-solid)as an opaque background when maximized, covering all themes (default, custom translucent sidebar, and built-in themes with semi-transparent--cardvalues).Test Plan
Demo
Before (chat bleeds through maximized workspace panel):
Type of change
Test coverage
Coverage notes
CSS-only fix plus one data attribute. Verified manually by maximizing the workspace panel in dark mode and confirming the background is opaque. No automated test covers glassmorphism rendering.
Changelog
Maximized workspace panel no longer shows chat content through a transparent background in dark mode.