Skip to content

fix(forum): derive topic author from JWT session instead of request body #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
omkarhole merged 1 commit into from
Jun 2, 2026
Merged

fix(forum): derive topic author from JWT session instead of request body #269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions backend/controllers/forum.controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,16 @@ async function listForums(req, res, next) {
res.json(forums);
} catch (err) { next(err); }
}
// add new forum topic
// add new forum topic - author is always the authenticated caller (#263)
async function addForum(req, res, next) {
try {
const topicData = {
title: req.body.title,
description: req.body.description,
user: req.body.user_id || req.body.user
// Always derive the author from the verified JWT payload.
// Trusting req.body.user_id or req.body.user allows any
// authenticated caller to impersonate another user.
user: req.user.id || req.user._id,
};
const topic = await ForumTopic.create(topicData);
res.status(201).json(topic);
Expand Down
Loading