Feature/share experiments #66
Conversation
src/api_service/views.py
Outdated
| ) | ||
|
|
||
| experiment.shared_institutions.remove(institution) | ||
| experiment.save() |
There was a problem hiding this comment.
Cuando se hacen cambios en relaciones ManyToMany como en la línea de arriba, no es necesario hacer un save(). Este métodos solo debe llamarse cuando se edita algún campo particular, y se debe llamar solo sobre el modelo cambiado:
experiment.name = 'X'
experiment.save()
# O...
experiment.user.apellido = 'Sanchez'
experiment.user.save() # Fijate que el save() solo es en el objeto cambiadoPor ende, eliminar esta línea
src/api_service/views.py
Outdated
| ) | ||
|
|
||
| experiment.shared_users.remove(user) | ||
| experiment.save() |
src/api_service/views.py
Outdated
| ) | ||
|
|
||
| experiment.is_public = not experiment.is_public | ||
| experiment.save() |
There was a problem hiding this comment.
Para optimizar la performance del guardado, se puede pasar un parámetro llamado update_fields que hace que el UPDATE que ejecuta el ORM por atrás solo incluya ese campo. Cambiar a experiment.save(update_fields=['is_public'])
src/api_service/views.py
Outdated
| experiment = get_object_or_404(Experiment, id=experiment_id) | ||
|
|
||
| associated_user_ids = experiment.shared_users.values_list('id', flat=True) | ||
| print(associated_user_ids) |
src/api_service/views.py
Outdated
| institution = get_object_or_404(Institution, id=institution_id) | ||
|
|
||
| experiment.shared_institutions.add(institution) | ||
| experiment.save() |
src/api_service/views.py
Outdated
| experiment.save() | ||
|
|
||
| serializer = InstitutionSerializer(institution) | ||
| return Response(serializer.data, status=status.HTTP_200_OK) |
There was a problem hiding this comment.
Sacar el status acá ya que por defecto es el 200
src/api_service/views.py
Outdated
| user = get_object_or_404(User, id=user_id) | ||
|
|
||
| experiment.shared_users.add(user) | ||
| experiment.save() |
| @@ -92,6 +92,10 @@ export class InstitutionsPanel extends React.Component<{}, InstitutionsPanelStat | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * Default modal. | |||
| * @returns {ConfirmModal} | |||
There was a problem hiding this comment.
Ojo los warnings de ESLint, correr npm run check-lint o npm run check-all para ver todos los warnings
| ) : | ||
| ( | ||
| <Icon | ||
| title='If this is checked all the users in the platform can see (but not edit or remove) this element' |
There was a problem hiding this comment.
Ojo, quedó el mismo title que arriba!
No description provided.