Feature/share experiments #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Genarito
reviewed
Feb 3, 2025
| @@ -63,6 +63,9 @@ class ExperimentSerializer(serializers.ModelSerializer): | |||
| """Experiment serializer""" | |||
| mRNA_source = ExperimentSourceSerializer() | |||
| gem_source = ExperimentSourceSerializer() | |||
| shared_institutions = InstitutionSimpleSerializer(many=True, read_only=True) | |||
| #shared_institutions = InstitutionSimpleSerializer() | |||
Genarito
reviewed
Feb 3, 2025
| open={props.isOpen} | ||
| closeIcon={<Icon name='close' size='large' onClick={() => props.handleClose()} />} | ||
| > | ||
| <ModalHeader>Select a Photo</ModalHeader> |
There was a problem hiding this comment.
Ojo con esto! Quedó un ejemplo acá, abajo dice Helen también. Dice institutionName={'asd'} institutionId={4}. Borrar todos estos datos hardcodeados!
Genarito
reviewed
Feb 3, 2025
| } | ||
| } | ||
|
|
||
| /** | ||
| * Generates default table's Filters | ||
| * @returns Default object for table's Filters | ||
| */ | ||
| getDefaultFilters (): PaginationCustomFilter[] { | ||
| getDefaultFilters(): PaginationCustomFilter[] { |
There was a problem hiding this comment.
Correr el comando npm run fix-link para ver los warnings y después el npm run check-link para verificar que no salten más warnings. Porque está lleno de alertas de ESLint, que es la herramienta que chequea que todos los estándares de programación de frontend se están respetando. Cualquier cosa consultale a Juan!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.