Skip to content

Appended count of modules by state in admin/module. #2441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Daniel-KM wants to merge 1 commit into
base: develop
Choose a base branch
from
+16 −2
Open

Appended count of modules by state in admin/module. #2441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions application/src/Controller/Admin/ModuleController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,23 @@ public function browseAction()
return strcmp(strtolower($a->getName()), strtolower($b->getName()));
});

// Count modules per filter state.
$allModules = $this->omekaModules->getModules();
$moduleCounts = [
'' => count($allModules),
'active' => count($this->omekaModules->getModulesByState('active')),
'not_active' => count($this->omekaModules->getModulesByState('not_active')),
'not_installed' => count($this->omekaModules->getModulesByState('not_installed')),
'needs_upgrade' => count($this->omekaModules->getModulesByState('needs_upgrade')),
'error' => count($this->omekaModules->getModulesByState('not_found'))
+ count($this->omekaModules->getModulesByState('invalid_module'))
+ count($this->omekaModules->getModulesByState('invalid_ini')),
];

$view = new ViewModel;
$view->setVariable('modules', $modules);
$view->setVariable('filterState', $state);
$view->setVariable('moduleCounts', $moduleCounts);
$view->setVariable('filterStates', [
'active' => $this->translate('Active'),
'not_active' => $this->translate('Not active'),
Expand Down
4 changes: 2 additions & 2 deletions application/view/omeka/admin/module/browse.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ $this->plugin('formRow')->setPartial(null);

<form method="get" class="state-filter">
<select name="state" aria-label="<?php echo $translate('Filter'); ?>">
<option value=""><?php echo $translate('All modules'); ?></option>
<option value=""><?php echo sprintf('%s (%d)', $translate('All modules'), $moduleCounts['']); ?></option>
<?php foreach ($filterStates as $value => $option): ?>
<option value="<?php echo $escape($value); ?>"<?php if ($value == $filterState): echo ' selected'; endif; ?>><?php echo $escape($option); ?></option>
<option value="<?php echo $escape($value); ?>"<?php if ($value == $filterState): echo ' selected'; endif; ?>><?php echo sprintf('%s (%d)', $escape($option), $moduleCounts[$value]); ?></option>
<?php endforeach; ?>
</select>
</form>
Expand Down