Fixed check of matched route in cli.#2439
Open
Daniel-KM wants to merge 1 commit intoomeka:developfrom
Open
Conversation
Contributor
Author
|
But, unlike the previous pr like composer, this fix may have complex implications with modules that rely on matched routes during jobs, so it should be verified in various contexts. Anyway, i included a similar check in module CleanUrl too. |
Contributor
Author
|
This is not only CleanUrl that breaks background job : there is Metadata Browse too, that does not check it. The fix in omeka-s-modules/MetadataBrowse#54 is not yet released in a new version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were some issues on the forum on CleanUrl that break csv import. So this patch avoids to prepare the route in cli context.