Open
Conversation
Daniel-KM
force-pushed
the
feat/go_back_modules
branch
from
fb79aa0 to
4e8c6c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When updating many modules (and i just updated about 20 modules to manage them via composer), it is non-ux friendly to go back to the full list of modules after each upgrade, so this pr define a redirect after upgrade (and after other selected states).
Furthermore, when there is an error but errors are not displayed on the server (no error on screen on production), it is useful to know it immediately without going to change .htaccess manually, see the issue, and revert back to production in .htaccess. So the second commit adds a error message via messenger.