Remove unrelated elements when changing item type#865
Open
luku wants to merge 1 commit intoomeka:masterfrom
Open
Remove unrelated elements when changing item type#865luku wants to merge 1 commit intoomeka:masterfrom
luku wants to merge 1 commit intoomeka:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This partially solves situation, where changing item type of an item keeps already filled information in elements not associated with new item type.
The problem is mostly apparent when searching, because all existing element texts are indexed, but not visible in show pages.
There's still issue when removing element association for specific item type and when removing element completely from Omeka. But it's less common case and users can be prompted to reindex search.